Repository navigation
fix: deletion behaviors - #290
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Mock payload tests cannot establish whether server-side apply removes existing targets’ owner references and prevents garbage collection, so retention requires live-cluster validation.
No open issues 🎉
What changed in this PR
This PR refines Sinker’s deletion behavior so target ownership respects retention settings and deletion-related metadata changes trigger reconciliation.
Changes:
- Limit automatic owner references to local, same-namespace targets with target deletion enabled.
- Extend event filtering to detect deletion state and deletion-control annotation changes.
- Add regression coverage and update documentation for ownership, retention, and reconciliation triggers.
| File | Description |
|---|---|
src/remote_watcher.rs |
Removes TODO comments; no runtime behavior changes. |
src/controller.rs |
Updates ownership rules and event filtering, with regression tests. |
README.md |
Explains revised retention behavior and reconciliation triggers. |
AGENTS.md |
Aligns contributor guidance with the updated deletion and ownership rules. |
Review effort: Balanced
zach-robinson-dev
marked this pull request as ready for review
November 13, 2026 20:42
zach-robinson-dev
enabled auto-merge
November 13, 2026 20:42
jenniferplusplus
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up some deletion-related behaviors.